Skip to content

[example] Use event time in multiple agent workflow example #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2025
Merged

[example] Use event time in multiple agent workflow example #273

merged 1 commit into from
Nov 26, 2025

Conversation

@Sxnan
Copy link
Contributor

@Sxnan Sxnan commented Oct 13, 2025 •
edited
Loading

Linked issue: #264

Purpose of change

  • Fix tool conversion in openai_chat_model
  • Always include the assistant message after the prompt is applied
  • Use event time in the multiple agent workflow example.

Tests

API

Documentation

@Sxnan
Copy link
Contributor Author

Sxnan commented Oct 13, 2025

@xintongsong @wenjin272 Can you review this PR?

@wenjin272
Copy link
Collaborator

wenjin272 commented Oct 14, 2025

Verified the example, LGTM.

@Sxnan Sxnan force-pushed the quickstart-eventtime branch 2 times, most recently from e60030b to 096bf37 Compare November 13, 2025 10:03
@Sxnan Sxnan added priority/major Default priority of the PR or issue. affectVersion/0.2.0 The bug affects the 0.2.0 version. The features are not needed. doc-not-needed Your PR changes do not impact docs labels Nov 14, 2025
@GreatEugenius GreatEugenius added fixVersion/0.2.0 The feature or bug should be implemented/fixed in the 0.2.0 version. and removed affectVersion/0.2.0 The bug affects the 0.2.0 version. The features are not needed. labels Nov 14, 2025
@Sxnan Sxnan added the fixVersion/0.1.1 The feature or bug should be implemented/fixed in the 0.1.1 version. label Nov 20, 2025
@Sxnan Sxnan force-pushed the quickstart-eventtime branch from 096bf37 to 78e0a67 Compare November 21, 2025 07:36
xintongsong
xintongsong approved these changes Nov 25, 2025
View reviewed changes
Copy link
Contributor

@xintongsong xintongsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sxnan Sxnan merged commit bd2f9e7 into apache:main Nov 26, 2025
11 checks passed
Sxnan added a commit that referenced this pull request Nov 26, 2025
@Sxnan
[example] Use event time in multiple agent workflow example (#273)
086be35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xintongsong xintongsong xintongsong approved these changes

Assignees

No one assigned

Labels

doc-not-needed Your PR changes do not impact docs fixVersion/0.1.1 The feature or bug should be implemented/fixed in the 0.1.1 version. fixVersion/0.2.0 The feature or bug should be implemented/fixed in the 0.2.0 version. priority/major Default priority of the PR or issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Sxnan @wenjin272 @xintongsong @GreatEugenius